-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-4329: Appointment Scheduler: Start Visit Form Not Launching on First Click #2185
base: main
Are you sure you want to change the base?
Conversation
6cbd41e
to
8f40195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
FYI @donaldkibet |
Thanks @Bharath-K-Shetty! Could you please fix the failing build? Running |
37475a0
to
e60cbf9
Compare
@NethmiRodrigo Yeahh sure.As I’ve updated the versions of core and framework. I’ll run yarn again and follow the steps you mentioned.. Thank you for the review! |
53c6a45
to
b3beb05
Compare
Requirements
Summary
Fixed the issue where the "Start Visit" form did not launch on the first click.
Replaced the workspace launch method with launchPatientWorkspace.
Improved accessibility by adding an aria-label to the button.
It fixes in "Add patient to queue Form "also.
Screenshots
Before
start_visit.1.mov
After
Screen.Recording.2025-01-11.120310.mp4
Related
Issue
https://openmrs.atlassian.net/browse/O3-4329
Other