Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4329: Appointment Scheduler: Start Visit Form Not Launching on First Click #2185

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Bharath-K-Shetty
Copy link

@Bharath-K-Shetty Bharath-K-Shetty commented Jan 11, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • Fixed the issue where the "Start Visit" form did not launch on the first click.

  • Replaced the workspace launch method with launchPatientWorkspace.

  • Improved accessibility by adding an aria-label to the button.

  • It fixes in "Add patient to queue Form "also.

Screenshots

Before

start_visit.1.mov

After

Screen.Recording.2025-01-11.120310.mp4

Related

Issue

https://openmrs.atlassian.net/browse/O3-4329

Other

Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@denniskigen
Copy link
Member

FYI @donaldkibet

@NethmiRodrigo
Copy link
Collaborator

NethmiRodrigo commented Jan 15, 2025

Thanks @Bharath-K-Shetty! Could you please fix the failing build? Running yarn again should do the trick. If you updated the version of core and framework, make sure to run yarn again after yarn up openmrs@next @openmrs/esm-framework@next && git checkout package.json. See here - https://o3-docs.openmrs.org/docs/frontend-modules/development#i-see-errors-about-missing-apis-when-i-run-the-app

@Bharath-K-Shetty
Copy link
Author

@NethmiRodrigo Yeahh sure.As I’ve updated the versions of core and framework. I’ll run yarn again and follow the steps you mentioned.. Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants