(feat) O3-4313: Add MUAC to vitals header #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +95 B (0%) Total Size: 16.1 MB ℹ️ View Unchanged
|
|
Mind sharing a screenshot of how this looks on tablet, @NethmiRodrigo? If space is constrained, we might consider only showing it if the response contains any |
|
@denniskigen added a screenshot. I don't know why the e2e test fails, it passes locally and is unrelated to these changes... |
|
Yeah, I see. We probably only want to render this conditionally so we don't waste the screen real estate if a MUAC value is not available. |
|
@denniskigen Yes, exactly I think if an implementation uses MUAC as a vital sign, then it should display in the vitals header, but I think it's not always used, right? |
NethmiRodrigo
force-pushed
the
feat/O3-4313
branch
from
ba37687 to
f839b35
Compare
|
Few things to say here:
|
Having this driven through a configuration will sort many things. In Kenya, MUAC is a required variable for the category of patients it serves. |
|
@ojwanganto FWIW, MUAC is already displayed, it's just in the Biometrics table rather than the Vitals table. All this PR does is move it into the Vitals table, but then that makes that table very wide which wouldn't be great for tablet use-cases. |
I get it, thanks. I just supported your bullet point 3 about configuration. |
|
@ibacher MUAC wasn't changed from the vitals table from the biometric table. It doesn't change either of the tables at all. This PR just adds MUAC to the vitals and biometric header. |
|
My misreading. Let's add it in then. |
ibacher
approved these changes
Jan 10, 2025
NethmiRodrigo
force-pushed
the
feat/O3-4313
branch
from
51ab1fe to
345d092
Compare
denniskigen
approved these changes
Jan 15, 2025
|
@samuelmale might you have a clue why E2E tests related to the form engine are failing here? |
(Checkout Slack thread: https://openmrs.slack.com/archives/C084FQT1G64/p1736419624861609) |
|
Ah, I see. Thanks for the context, @samuelmale. The link you shared doesn't plop me over to the right place. Mind mentioning me on the thread so I get linked to it? |
|
@NethmiRodrigo @samuelmale Looks like the e2e heisenbug self-resolved. Nature is healing 🕺🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds the functionality to display MUAC in the vitals header component if it is present.
Screenshots
If MUAC is present:
If MUAC is not present:
Related Issue
https://issues.openmrs.org/browse/O3-4313
Other