Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Makes pre-release version numbers incremental #462

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

pirupius
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Pre-release version number has been using the current release version numbers which didn't make sense especially because pre-release should point to the next possible version.

Screenshots

Previously:
Screenshot 2025-01-29 at 14 29 15

New:
Screenshot 2025-01-29 at 21 06 41

Related Issue

Other

@pirupius pirupius requested a review from samuelmale January 29, 2025 18:14
Copy link

github-actions bot commented Jan 29, 2025

Size Change: 0 B

Total Size: 1.27 MB

ℹ️ View Unchanged
Filename Size
dist/151.js 382 kB
dist/225.js 2.58 kB
dist/260.js 114 kB
dist/277.js 11.9 kB
dist/353.js 3.02 kB
dist/41.js 3.37 kB
dist/422.js 3.05 kB
dist/499.js 2.51 kB
dist/540.js 2.63 kB
dist/606.js 2.24 kB
dist/635.js 14.4 kB
dist/658.js 1.86 kB
dist/727.js 87.2 kB
dist/929.js 265 kB
dist/979.js 6.87 kB
dist/993.js 3.09 kB
dist/main.js 358 kB
dist/openmrs-esm-form-engine-lib.js 3.8 kB

compressed-size-action

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pirupius. I've left some suggestions inspired by CI workflow files from elsewhere in the O3 ecosystem.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pirupius pirupius force-pushed the chore/make-pre-release-versions-incremental branch from a9fad3a to 6e19e8d Compare January 30, 2025 07:05
@pirupius
Copy link
Member Author

Thanks @denniskigen for the comments. Merging this in to unblock the release

@pirupius pirupius merged commit 8621049 into main Jan 30, 2025
6 checks passed
@pirupius pirupius deleted the chore/make-pre-release-versions-incremental branch January 30, 2025 07:14
- name: 💾 Commit changes
run: git add . && git commit -m "Prerelease version" --no-verify

- name: 🚀 Pre-release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this to Publish Pre-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants