Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4410: Adjust Form Workspace Size & Enhance Form UI #461

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

vasharma05
Copy link
Member

@vasharma05 vasharma05 commented Jan 29, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The forms workspace should be rendered in a wider workspace size. The following changes are made so that the form renders in a proper manner.

  1. The sidebar should be hidden for narrow workspace size
  2. The sidebar links and buttons should have a sm size for desktop view
  3. The file uploader buttons expand through the form space. The buttons should wrap accordingly.
  4. The accordion by default has a padding-right of 2.5rem, which takes up the space necessary for rendering form content.

Screenshots

Comparision of before and after scenarios.

Screen.Recording.2025-01-29.at.19.29.17.mov

Related Issue

https://openmrs.atlassian.net/browse/O3-4410

Other

Copy link

Size Change: +896 B (+0.07%)

Total Size: 1.27 MB

ℹ️ View Unchanged
Filename Size Change
dist/151.js 382 kB 0 B
dist/225.js 2.58 kB 0 B
dist/260.js 114 kB 0 B
dist/277.js 11.9 kB 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.37 kB 0 B
dist/422.js 3.05 kB 0 B
dist/499.js 2.51 kB 0 B
dist/540.js 2.63 kB 0 B
dist/606.js 2.24 kB 0 B
dist/635.js 14.4 kB 0 B
dist/658.js 1.86 kB 0 B
dist/727.js 87.2 kB 0 B
dist/929.js 265 kB +416 B (+0.16%)
dist/979.js 6.87 kB 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 358 kB +480 B (+0.13%)
dist/openmrs-esm-form-engine-lib.js 3.8 kB 0 B

compressed-size-action

@vasharma05 vasharma05 changed the title (fix) Change the form workspace size and improve form's UI (fix) O3-4410: Change the form workspace size and improve form's UI Jan 29, 2025
@vasharma05 vasharma05 changed the title (fix) O3-4410: Change the form workspace size and improve form's UI (fix) O3-4410: Adjust Form Workspace Size & Enhance Form UI Jan 29, 2025
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct according to the designs.

@ibacher ibacher merged commit 40b74fc into main Jan 29, 2025
6 checks passed
@ibacher ibacher deleted the fix/form-sidebar-view-conditions branch January 29, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants