Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3980: Synchronize Highlighting Between Interactive Builder and Schema Editor #379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Twiineenock
Copy link
Contributor

@Twiineenock Twiineenock commented Jan 21, 2025

…ma Editor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • The question selection is not synchronized between the interactive builder and schema editor.

  • When a question is highlighted in either the interactive builder or schema editor, it should automatically reflect and be highlighted in the other interface.

Screenshots

h1

Screancasts

  • Clicking in the Schema editor
    h1.webm

  • Clicking in the Interactive builder
    h2.webm

Related Issue

https://openmrs.atlassian.net/browse/O3-3980

Other

@NethmiRodrigo NethmiRodrigo self-requested a review January 21, 2025 12:09
Copy link
Collaborator

@NethmiRodrigo NethmiRodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Twiineenock thank you for picking this up. A couple of things,

  1. Please update the PR description
  2. A question in the interactive editor gets the highlighted styles only if you select a question on the schema editor, it'll be better if it gets highlighted when you click on the question. This is important because even when you select another question on the interactive builder, the previous question stays highlighted.
  3. The app breaks when you go back from a form
Screen.Recording.2025-01-22.at.2.46.20.PM.mov

@Twiineenock
Copy link
Contributor Author

@Twiineenock thank you for picking this up. A couple of things,

  1. Please update the PR description
  2. A question in the interactive editor gets the highlighted styles only if you select a question on the schema editor, it'll be better if it gets highlighted when you click on the question. This is important because even when you select another question on the interactive builder, the previous question stays highlighted.
  3. The app breaks when you go back from a form

Screen.Recording.2025-01-22.at.2.46.20.PM.mov

Thanks @NethmiRodrigo for catching those, I will be sure to fix them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants