(feat) Various improvements to the interactive builder #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
force-pushed
the
feat/interactive-builder-enhancements
branch
from
862f86a to
d70abfd
Compare
|
Size Change: +26.6 kB (+1%) Total Size: 3.17 MB
ℹ️ View Unchanged
|
denniskigen
force-pushed
the
feat/interactive-builder-enhancements
branch
3 times, most recently
from
81729c5 to
c1fc3f5
Compare
denniskigen
force-pushed
the
feat/interactive-builder-enhancements
branch
from
c1fc3f5 to
0123f2c
Compare
hadijahkyampeire
approved these changes
Mar 19, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR enhances the add question modal in the interactive builder by introducing granular handling of question types. Depending on the selected question type, the rendering types dropdown will display only the applicable options to ensure a consistent and logical user experience. The specific changes are:
For the
controlquestion type, the rendering types dropdown showstextas the only available option since control fields are of type text.For the
encounterDatetimequestion type, the rendering types dropdown showsdate. Additionally, a radio button group allows selecting a standalone calendar, a standalone timer, or a combined calendar and timer in the date picker.For the
encounterLocationquestion type, the rendering types dropdown showsui-select-extendedsince these fields are wired up to the location data source.For the
encounterProviderquestion type, the rendering types dropdown showsui-select-extendedsince these fields are wired up to the provider data source.For the
obsGrouportestOrderquestion types, the rendering types dropdown listsgroupandrepeatingas the available options.For the
personAttributequestion type, the rendering types dropdown listsselect,text, andui-select-extendedas the available options.personAttributefields are backed by a person attribute type. So we show a ComboBox that allows users to search through the person attribute types configured in the system and select a backing person attribute type. A future iteration will add a dropdown for selecting the answers to display as choices for person attribute types linked to concepts.For the
obsquestion type, we show all the available rendering types in the dropdown.This change ensures that users can only select valid rendering types for each question type, reducing confusion and potential errors.
Screenshots
interactive-builder-question-types.mp4
Related Issue
Other