TRUNK-6262 Make form resource auditable #4714
Conversation
… formResource-auditable
There was a problem hiding this comment.
All PRs require a ticket. The ticket needs to explain the change and why it's being made and what the goals are. It's hard to review this without that. My sense is that implementing BaseChangeableOpenmrsMetadata is a massive semantic change. Specifically, we don't really support the idea of "retired" form resources (which is why we need documentation on why this change is being done and why).
In terms of the technical details, all of the liquibase changes should be a single change set to the update script. The update also need to be applied to the update-to-2.7. We don't, as a general rule, backport data model changes and never as far as two versions back.
icrc-loliveira
changed the title
|
Hi @ibacher , |
|
@icrc-loliveira Are you able to address the comments I made above? |
Description of what I changed
Changed the class
FormResourcetoBaseChangeableOpenmrsMetadatainsted ofBaseOpenmrsObjectIssue I worked on
see (https://openmrs.atlassian.net/browse/TRUNK-6262)
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master