Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build type problem #201

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix Windows build type problem #201

merged 1 commit into from
Apr 22, 2024

Conversation

godotalgorithm
Copy link
Collaborator

Windows executables are presently being built with a "Debug" build type and thus debug flags rather than optimization flags, which is slowing down the distributed Windows executables for MOPAC. This is an open PR for repairing the CMake and GHA scripts to fix this problem.

Status

  • Ready for merge

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.75%. Comparing base (a22996f) to head (bef9537).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files         332      332           
  Lines       74082    74082           
=======================================
  Hits        49456    49456           
  Misses      24626    24626           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godotalgorithm godotalgorithm merged commit e7a5c3f into main Apr 22, 2024
9 checks passed
@godotalgorithm
Copy link
Collaborator Author

The problem was that CMAKE_BUILD_TYPE was being set too late, and for whatever reason it still working on Mac and Linux even though it was technically wrong. CMAKE_BUILD_TYPE is used when the project() or enable_language() commands are used in CMake, and so it needs to be set before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant