Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-implement import-sql using Python #378

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

re-implement import-sql using Python #378

wants to merge 5 commits into from

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Oct 2, 2021

closes #376

@nyurik nyurik requested a review from TomPohys October 2, 2021 05:13
Falke-Design referenced this pull request in openmaptiles/openmaptiles Oct 2, 2021
@Falke-Design
Print error of import-sql at the end of the output (#1237)
6f0ab57 
Because of the parallel processing of `import-sql` the error message is printed in the middle of the output. With this PR the error is displayed again at the end:
![grafik](https://user-images.githubusercontent.com/19800037/133897373-656ed3d0-e580-4f67-9290-0e83949d63d7.png)

Issue: openmaptiles/openmaptiles-tools#370

```
awk '1{print; fflush()} $$0~".*ERROR" {txt=$$0} END{ if(txt){print "\n*** ERROR detected, aborting:"; print txt; exit(1)} }'
```
Explanation:
- `1{print; fflush()}` means if true then print output -> `1{}` same as `if(true){}`
- `$$0~".*ERROR" {txt=$$0}` get first argument `$$0` (line of output) and check if it contains (regex string) `ERROR`. If true save line to var `txt`: `{txt=$$0}`
- `END{ ... }` if last line of output is reached
- `if(txt){print "\n*** ERROR detected, aborting:"; print txt; exit(1)}` if error was found in a line / var `txt` is existing print it out
TomPohys
TomPohys reviewed Oct 6, 2021
View reviewed changes
bin/import-sql Outdated Show resolved Hide resolved
TomPohys
TomPohys reviewed Oct 6, 2021
View reviewed changes
README.md Show resolved Hide resolved
@nyurik @TomPohys
Update bin/import-sql
008db80 
Co-authored-by: Tomas Pohanka <[email protected]>
@nyurik nyurik requested a review from TomPohys October 6, 2021 17:11
@TomPohys
Copy link
Member

TomPohys commented Oct 6, 2021

Thanks! Is this also fixing #373?

@nyurik
Copy link
Member Author

nyurik commented Oct 6, 2021

Thanks! Is this also fixing #373?

The #373 can be merged as is. No need to wait. The issue is that OMT itself wouldn't print errors "as nicely" with it, but its not a big deal.

@TomPohys TomPohys mentioned this pull request Oct 8, 2021
Merged
@nyurik nyurik marked this pull request as draft October 12, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomPohys TomPohys TomPohys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reimplement import-sql in python
2 participants
@nyurik @TomPohys