-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reference extraction with HTML #2
Conversation
Hi @fchrubasik thank you very much for your contribution! I would be happy to merge this but before I do so we definitely need to add a unit test to verify that this feature is working correctly. Also, please check on the existing unit tests, since they are currently failing: https://travis-ci.org/openlegaldata/legal-reference-extraction/jobs/621724640
Let me know if you need any assistance, I'm here to help! Best, |
Hi @malteos, the existing unit test should now work. I also added new unit tests based on the existing tests. Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you so much for this Christmas gift. I'll try to deploy this to our production system asap.
Finally deployed to production! Sorry for the delay. |
The extractor now also works with input as HTML. This should be a bugfix for issue #1 as
discussed here.
The default is currently set as non-HTML. To change this simply add the argument
True
when executing
extractor.extract
or change the default value ofis_html
in line 47 ofextractors.py
toTrue
.