8341687: Memory leak in TableView after interacting with TableMenuButton #1640
+163
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple issues in the
TableMenu
logic that result in a memory leak.The following problems are now fixed with this PR:
col.visibleProperty()
was not weak nor was it ever unregisteredcol.textProperty()
listenercol.visibleProperty()
andcol.textProperty()
where added again and again and again to the column when the columns changed (which happens when toggling the visibility).MenuItem
is created. This way, when theTableMenu
is rebuild and the cachedMenuItem
is used, the whole listener logic is not run again for the columnProgress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1640/head:pull/1640
$ git checkout pull/1640
Update a local copy of the PR:
$ git checkout pull/1640
$ git pull https://git.openjdk.org/jfx.git pull/1640/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1640
View PR using the GUI difftool:
$ git pr show -t 1640
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1640.diff
Using Webrev
Link to Webrev Comment