JavaFX Incubator Modules #1375
JavaFX Incubator Modules #1375
Conversation
Initial prototype of a javafx.incubator.controls module
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
|
I pushed the following updates:
|
| private static final Module MODULE_JAVA_BASE = Module.class.getModule(); | ||
|
|
||
| @SuppressWarnings("removal") | ||
| public static void incubatorWarning() { |
There was a problem hiding this comment.
perhaps we can add a javadoc to this method explaining why it is here and giving a usage example?
|
Incubator warning works as expected: |
|
❗ This change is not yet ready to be integrated. |
|
BTW, should we have a separate, real PR with changes only for enabling the functionality (.md file and build.gradle, the latter with sample module changes commented out - maybe with an easy to grep marker for anyone who wants to add a new incubator module)? |
Yes, something along those lines is in the works. I've already identified many of the changes that would be part of this separate Enhancement, and marked them with I'm not sure yet what the best way is to show where to add the logic for a new incubator module. At least having an easy-to-find "incubator modules go here" comment would be helpful and seems like a good idea. As you suggest, I could go farther than that and add commented-out build logic for the sample module...need to think about that one. I would not be in favor of including the sample module, though, so I'm leaning towards just adding the appropriate markers in build.gradle, but not any actual build logic for an incubator modules. Anyone doing an incubator module would need to grab the sample patch anyway. |
| 'graphics', | ||
| 'controls', | ||
| // TODO: incubator template | ||
| 'incubator.myfeature', |
There was a problem hiding this comment.
this change fixed the jenkins build of the rich text area incubator, thank you!
|
@kevinrushforth This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
|
kevinrushforth
force-pushed
the
javafx.incubator
branch
from
1f567a9
to
4bb1b59
Compare
I pushed the wrong merge commit, so corrected it before (I hope) anyone other than Skara noticed. I wouldn't do this except that this is a Draft PR that I don't intend to ever make I plan to close this Draft PR soon anyway, and create a new PR from a clean branch. |
|
@kevinrushforth This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Keep alive |
This PR contains a proposal for JavaFX Incubator Modules, along with an example of how such a module might be implemented.
NOTE: This PR will remain in Draft. It is intended only as supporting material for the proposal.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1375/head:pull/1375$ git checkout pull/1375Update a local copy of the PR:
$ git checkout pull/1375$ git pull https://git.openjdk.org/jfx.git pull/1375/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1375View PR using the GUI difftool:
$ git pr show -t 1375Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1375.diff