Fix decoding of CLRI, BINVI, BSETI, BEXTI and RORI where bit 25 is reserved in RV32 Fix #2280 #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
core/decoder.sv
Outdated
Comment on lines
941
to
944
| else if (CVA6Cfg.IS_XLEN64 && instr.instr[31:26] == 6'b010_010) instruction_o.op = ariane_pkg::BEXTI; | ||
| else if (CVA6Cfg.IS_XLEN32 && instr.instr[31:25] == 7'b010_0100) instruction_o.op = ariane_pkg::BEXTI; | ||
| else if (CVA6Cfg.IS_XLEN64 && instr.instr[31:26] == 6'b011_000) instruction_o.op = ariane_pkg::RORI; | ||
| else if (CVA6Cfg.IS_XLEN32 && instr.instr[31:25] == 7'b011_0000) instruction_o.op = ariane_pkg::RORI; |
There was a problem hiding this comment.
[verible-verilog-format] reported by reviewdog 🐶
Suggested change
| else if (CVA6Cfg.IS_XLEN64 && instr.instr[31:26] == 6'b010_010) instruction_o.op = ariane_pkg::BEXTI; | |
| else if (CVA6Cfg.IS_XLEN32 && instr.instr[31:25] == 7'b010_0100) instruction_o.op = ariane_pkg::BEXTI; | |
| else if (CVA6Cfg.IS_XLEN64 && instr.instr[31:26] == 6'b011_000) instruction_o.op = ariane_pkg::RORI; | |
| else if (CVA6Cfg.IS_XLEN32 && instr.instr[31:25] == 7'b011_0000) instruction_o.op = ariane_pkg::RORI; | |
| else if (CVA6Cfg.IS_XLEN64 && instr.instr[31:26] == 6'b010_010) | |
| instruction_o.op = ariane_pkg::BEXTI; | |
| else if (CVA6Cfg.IS_XLEN32 && instr.instr[31:25] == 7'b010_0100) | |
| instruction_o.op = ariane_pkg::BEXTI; | |
| else if (CVA6Cfg.IS_XLEN64 && instr.instr[31:26] == 6'b011_000) | |
| instruction_o.op = ariane_pkg::RORI; | |
| else if (CVA6Cfg.IS_XLEN32 && instr.instr[31:25] == 7'b011_0000) | |
| instruction_o.op = ariane_pkg::RORI; |
Gchauvon
force-pushed
the
dev/b-decoder
branch
from
94d54a3 to
a9d8a63
Compare
|
❌ failed run, report available here. |
3 similar comments
|
❌ failed run, report available here. |
|
❌ failed run, report available here. |
|
❌ failed run, report available here. |
|
✔️ successful run, report available here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix decoding of some bitmanip instruction where decoding differs between rv32 and rv64