Skip to content

Commit

Permalink
💄(lock course) spaces between forums names
Browse files Browse the repository at this point in the history
When a course has multiple forums, the listing can be
very long. We don't want the user to have to scroll
too much before showing the confirmation button to
lock the course.
  • Loading branch information
carofun committed Jun 13, 2022
1 parent 6ddffbb commit 6cd3efc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]


### Changed

- Reduce spaces between forums names on the lock page

## [1.2.2] - 2022-06-08

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion src/ashley/templates/forum/forum_lock.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ <h3 class="m-0 h5 card-title">{% trans "Lock the forum" %}</h3>
<div class="card-body">
<div class="mb-3 warning-message">
<p>{% trans "Are you sure you want to lock the entire course? All the forums in this course will be locked." %}</p>
{% for forum in forums_list %}<p class="ml-3 pb-3"><strong>{{ forum.name }}</strong><p>{% endfor %}
{% for forum in forums_list %}<p class="ml-3 mb-0"><strong>{{ forum.name }}</strong></p>{% endfor %}
</div>
<form method="post" action="." class="form" enctype="multipart/form-data" novalidate>{% csrf_token %}
<div class="row">
Expand Down
6 changes: 3 additions & 3 deletions tests/ashley/test_course_locked.py
Original file line number Diff line number Diff line change
Expand Up @@ -788,9 +788,9 @@ def test_course_create_multiple_forums_listing_on(self):
self.assertEqual(200, response.status_code)
# this listing is common for all the forums of the course
forums_list = (
f'<p class="ml-3 pb-3"><strong>{forum1.name}</strong><p>'
'<p class="ml-3 pb-3"><strong>Forum2</strong><p>'
'<p class="ml-3 pb-3"><strong>Forum3</strong><p>'
f'<p class="ml-3 mb-0"><strong>{forum1.name}</strong></p>'
'<p class="ml-3 mb-0"><strong>Forum2</strong></p>'
'<p class="ml-3 mb-0"><strong>Forum3</strong></p>'
)
self.assertContains(response, forums_list)

Expand Down

0 comments on commit 6cd3efc

Please sign in to comment.