Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add some user info in /cgi/auth.pl body #9918

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

stephanegigandet
Copy link
Contributor

fixes #9910

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

cgi/auth.pl Outdated
@@ -55,6 +55,11 @@
user => {
email => $User{email},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shan't we remove it then ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgarel It might be used by the mobile app, I'm not really sure... #7455

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing the email and asking about it in openfoodfacts/openfoodfacts-dart#893 (comment)

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@stephanegigandet stephanegigandet merged commit 93b4abf into main Mar 15, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the auth-info branch March 15, 2024 14:16
Payne680 pushed a commit to Payne680/openfoodfacts-server that referenced this pull request Mar 15, 2024
* fix: add some user info in /cgi/auth.pl body openfoodfacts#9910

* removing email
john-gom pushed a commit that referenced this pull request May 24, 2024
* fix: add some user info in /cgi/auth.pl body #9910

* removing email
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants