Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HTML addition for youtube link for pro platform #8407 #8418

Closed
wants to merge 5 commits into from
Closed

fix: HTML addition for youtube link for pro platform #8407 #8418

wants to merge 5 commits into from

Conversation

aadak99
Copy link
Contributor

@aadak99 aadak99 commented May 14, 2023 •
edited by alexgarel
Loading

Added link to nav menu as "Youtube tutorials"

I was having difficulty with setting up the pro dev container. I could see the (pro) in my git bash, but only po was produced not po_pro like expected. Regardless, I found the html page corresponding to the pro platform and put in a _blank link to youtube tutorial playlist.

@aadak99 aadak99 requested a review from a team as a code owner May 14, 2023 09:57
@github-actions github-actions bot added product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels May 14, 2023
@aadak99
Update site_layout.tt.html
ee2ba17 
Updated public platform to include producers menu link, promote discoverability.
@aadak99 aadak99 mentioned this pull request May 14, 2023
Closed
@alexgarel
Copy link
Member

@aadak99, I fixed the description, as you put fixes #[8407], the [] disabled the linking. Also it was #8408 (not your fault, there was a misleading #8407 in the title of the issue…)

alexgarel
alexgarel requested changes May 17, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing @aadak99, though we have to handle translations. See my comment above.

@aadak99 aadak99 requested a review from alexgarel May 17, 2023 15:01
aadak99
aadak99 commented May 17, 2023
View reviewed changes
Copy link
Contributor Author

@aadak99 aadak99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8332

Added Producers link to top nav, with translatable string

@sonarcloud
Copy link

sonarcloud bot commented May 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aadak99 aadak99 closed this by deleting the head repository May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel Awaiting requested review from alexgarel

Assignees

@aadak99 aadak99

Labels
product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a link to the Tutorials in the menu of the Pro platform
2 participants
@aadak99 @alexgarel