Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add data quality warning for serving size without digit #8057

Merged
merged 8 commits into from
Feb 6, 2023
Merged

feat: add data quality warning for serving size without digit #8057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
25c70ad
added warning for missing digit in serving_size
benbenben2 Jan 31, 2023
a65fcbd
update test for perltidy, finish dev for warning
benbenben2 Jan 31, 2023
76707b5
update following last message in #5163
benbenben2 Jan 31, 2023
5d31014
Merge branch 'main' into feat_add_data_quality_warning_serving_size_w…
benbenben2 Jan 31, 2023
bb9efcf
Update lib/ProductOpener/DataQualityFood.pm
benbenben2 Feb 1, 2023
b4631e9
Merge branch 'main' into feat_add_data_quality_warning_serving_size_w…
benbenben2 Feb 1, 2023
306253b
make lint
benbenben2 Feb 3, 2023
2b5fd7e
Merge branch 'main' into feat_add_data_quality_warning_serving_size_w…
benbenben2 Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/ProductOpener/DataQualityFood.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,13 @@ sub check_nutrition_data ($product_ref) {
"en:nutrition-data-prepared-without-category-dried-products-to-be-rehydrated";
}
}

if ( (defined $product_ref->{serving_size})
and ($product_ref->{serving_size} ne "")
and ($product_ref->{serving_size} !~ /\d/))
{
push @{$product_ref->{data_quality_errors_tags}}, "en:serving-size-is-missing-digits";
}
if ( $nutrition_data
and (defined $product_ref->{nutrition_data_per})
and ($product_ref->{nutrition_data_per} eq 'serving'))
Expand Down
16 changes: 16 additions & 0 deletions tests/unit/dataqualityfood.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,4 +486,20 @@ check_quality_and_test_product_has_quality_tag(
'nutriment should have positive value (except nutrition-score)', 0
);

# serving size should contains digits
$product_ref = {serving_size => "serving_size"};
ProductOpener::DataQuality::check_quality($product_ref);
check_quality_and_test_product_has_quality_tag(
$product_ref,
'en:serving-size-is-missing-digits',
'serving size should contains digits', 1
);
$product_ref = {serving_size => "120g"};
ProductOpener::DataQuality::check_quality($product_ref);
check_quality_and_test_product_has_quality_tag(
$product_ref,
'en:serving-size-is-missing-digits',
'serving size should contains digits', 0
);

done_testing();