Treat nil value on SecurityContext.ReadOnlyRootFilesystem as false

Add nil check when dereferencing SecurityContext.ReadOnlyRootFilesystem. This should fix a nil pointer dereference reported by a customer. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
openfaas · Nov 17, 2023 · bc569a6 · bc569a6
1 parent ffa794c
commit bc569a6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/main.go b/main.go
@@ -888,7 +888,10 @@ func readFunctions(deps []v1.Deployment) []Function {
 		function.Limits = lim
 
 		if functionContainer.SecurityContext != nil {
-			function.ReadOnlyRootFilesystem = *functionContainer.SecurityContext.ReadOnlyRootFilesystem
+			if functionContainer.SecurityContext.ReadOnlyRootFilesystem != nil {
+				function.ReadOnlyRootFilesystem = *functionContainer.SecurityContext.ReadOnlyRootFilesystem
+			}
+			function.ReadOnlyRootFilesystem = false
 		}
 
 		functions = append(functions, function)