Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register external commands before custom commands #50

Closed
wants to merge 7 commits into from
Closed

Register external commands before custom commands #50

wants to merge 7 commits into from

Conversation

claudiu-cristea
Copy link
Contributor

@claudiu-cristea claudiu-cristea commented Mar 25, 2018

ABANDONED IN FAVOUR OF #51

Problem

Right now, the dynamic/custom commands are registered in the TaskRunner constructor. The external commands, provided by 3rd party, are registered after TaskRunner has been constructed, in ./bin/run:

$runner = new TaskRunner();
$runner->registerExternalCommands($classLoader);

For this reason a custom command cannot add an external command as a task because at that moment the external command is not yet registered.

Solution

Call ::registerExternalCommands() from the TaskRunner constructor, just before calling ::registerDynamicCommands().

@claudiu-cristea
Copy link
Contributor Author

Abandoned in favour of #51

@claudiu-cristea claudiu-cristea deleted the register-external branch March 25, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant