EWPP-258: Create Behat test for testing "API steps" #315

georgebaev · 2020-10-08T11:40:13Z

This functionality adds the Behat tests for testing the API steps

drishu

I've updated the branch with latest master, so drone is red, but I see Adam is working on fixing the patch issues.

drishu · 2020-10-09T08:21:07Z

tests/features/api.feature

+      And I should see the text "A general contact"
+      And the "oe_organisation_eu_org[0][target_id]" field should contain "Arab Common Market (http://eurovoc.europa.eu/1793)"
+      And the "oe_organisation_org_type" field should contain "eu"
+      And the "Teaser" field should contain "My teaser"


Let's update the node with a non eu organisation type and check the value was set

drishu · 2020-10-09T08:21:37Z

tests/Behat/FeatureContext.php

+   *
+   * @When :option should be selected for :field select
+   */
+  public function shouldBeSelectedForSelect($option, $field) {


IF we wont use this let's remove it

I use this method in the refactored Behat statements

Don't we have this already from the Drupal extension?

drishu · 2020-10-09T08:22:47Z

tests/features/api.feature

+      And the "Registration capacity" field should contain "Event capacity"
+      And the "Entrance fee" field should contain "1234"
+      And I should see the text "Facebook"
+      And the "oe_event_registration_dates[0][value][day]" field should contain "1"


can't we use shouldBeSelectedForSelect in these situations ?

I refactored the statements

drishu · 2020-10-09T08:24:34Z

tests/features/api.feature

+      And I press "Edit" in the "A general contact" row
+      And I wait for AJAX to finish
+      And the "Phone number" field should contain "+32477792933"
+      And the "Country" field should contain "HU"


we should verify the rest of the address and the social media,
also check values of venue and press contact

I added statements which verify the values in the entity's View page.

drishu · 2020-10-09T08:30:53Z

tests/features/api.feature

+      And the "oe_project_calls[0][title]" field should contain "Info site"
+      And the "Results" field should contain "My Results"
+      And the "Teaser" field should contain "My teaser"
+      And I should see the text "A Stakeholder"


we should check for all avail values in the inline entity form for stackeholders, participants and general contact

georgebaev · 2020-10-14T10:37:59Z

@drishu I added the missing field values tests. Can you please review?

ademarco · 2020-11-03T11:09:09Z

tests/Behat/DateFieldContext.php

   *
-   * When I set "Field" to the date "22-02-2019"
-   * When I set "Field" to the date "22-02-2019 14:30" using format "d-m-Y H:i"
+   * Then datetime "15 1 2020 12 30" is selected for "Start date" of "Datetime"


Keep the previous format. Also avoid passive forms as much as possible:

Suggested change

* Then datetime "15 1 2020 12 30" is selected for "Start date" of "Datetime"

* When I set "22-02-2019 14:30" as "start date" for "Field name"

ademarco · 2020-11-03T11:09:30Z

tests/Behat/DateFieldContext.php

+   * @Then datetime :value is selected for :field_item of :field_group
+   * @Then date :value is selected for :field_item of :field_group
+   */
+  public function isSelectedForOf($value, $field_item, $field_group): void {


Type hinting are missing. Also in the other methods.

ademarco · 2020-11-03T11:10:30Z

tests/Behat/FeatureContext.php

+   * @Then the :field field contains :value
+   */
+  public function theFieldContains($field, $value) {
+    $node = $this->getSession()->getPage()->findField($field);


You need to first assert that the field exists, before trying to access its value. You can use assert session for this.

ademarco · 2020-11-03T11:11:23Z

tests/Behat/FeatureContext.php

+   *
+   * @When I press :button in the :rowText row
+   */
+  public function iPressInTheRow($button, $rowText) {


Missing type hints and code sniffing shouldn't have passed here, as camel case is not allowed for method parameters. Check if that actually runs on these classes too.

ademarco · 2020-11-03T11:11:53Z

tests/Behat/FeatureContext.php

+    $rows = $page->findAll('css', 'tr');
+
+    if (empty($rows)) {
+      throw new \Exception(sprintf('No rows found on the page %s', $this->getSession()->getCurrentUrl()));


You can use assert sessions to check presence of elements.

ademarco · 2020-11-03T11:12:41Z

tests/Behat/FeatureContext.php

+   *
+   * @When :option should be selected for :field select
+   */
+  public function shouldBeSelectedForSelect($option, $field) {


Don't we have this already from the Drupal extension?

ademarco · 2020-11-03T11:13:16Z

tests/features/api.feature

@@ -0,0 +1,320 @@
+@api @event
+  Feature: context API testing feature.


Indent properly at the beginning of the line.

ademarco · 2020-11-03T11:13:55Z

tests/features/api.feature

+      And the "Online description" field should contain "Event online description"
+      And datetime "21 2 2019 9 15" is selected for "Start date" of "Online time"
+      And datetime "21 2 2019 14 0" is selected for "End date" of "Online time"
+      And the "oe_event_online_link[0][title]" field should contain "Info site"


We don't do this in OpenEuropa, Behat scenarios have to be readable, we have several methods to make this possible, check other components for examples.

Also this is supposed to test our API steps right? Let's assert that values are set correctly by asserting that the expected values are printed out when viewing the node, not by asserting the form. oe_content can provide default view modes.

georgebaev requested a review from drishu October 8, 2020 11:40

drishu force-pushed the D8TEWPPE-73 branch from 33b972d to 97b1189 Compare October 9, 2020 07:53

drishu requested changes Oct 9, 2020

View reviewed changes

drishu and others added 10 commits October 15, 2020 10:13

D8TEWPPE-73: Add behat scenarios for api steps.

016dcb5

D8TEWPPE-73: Add steps.

315e7f0

D8TEWPPE-73: Add Project Content API steps test.

0a58740

D8TEWPPE-73: Alter the PhpCS related formatting.

6b7c230

D8TEWPPE-73: Add ContentContext tests.

3bc9040

D8TEWPPE-73: Alter the select Behat statements.

d3a097c

D8TEWPPE-73: Expand the Event Behat test.

7f5ccfa

D8TEWPPE-73: Test for correct social links.

555e019

D8TEWPPE-73: Expand the test fields set.

9f0d228

D8TEWPPE-73: Test the non-EU organisation type.

81ec44a

georgebaev force-pushed the D8TEWPPE-73 branch from 735889a to 81ec44a Compare October 15, 2020 10:51

georgebaev changed the title ~~D8TEWPPE-73: Create Behat test for testing "API steps"~~ EWPP-258: Create Behat test for testing "API steps" Oct 15, 2020

EWPP-258: Syntax improvement.

5489f27

ademarco requested changes Nov 3, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EWPP-258: Create Behat test for testing "API steps" #315

EWPP-258: Create Behat test for testing "API steps" #315

georgebaev commented Oct 8, 2020

drishu left a comment

drishu Oct 9, 2020

drishu Oct 9, 2020

georgebaev Oct 13, 2020

ademarco Nov 3, 2020

drishu Oct 9, 2020

georgebaev Oct 13, 2020

drishu Oct 9, 2020

georgebaev Oct 14, 2020

drishu Oct 9, 2020

georgebaev commented Oct 14, 2020

ademarco Nov 3, 2020

ademarco Nov 3, 2020

ademarco Nov 3, 2020

ademarco Nov 3, 2020

ademarco Nov 3, 2020

ademarco Nov 3, 2020

ademarco Nov 3, 2020

ademarco Nov 3, 2020

ademarco Nov 3, 2020

	* Then datetime "15 1 2020 12 30" is selected for "Start date" of "Datetime"
	* When I set "22-02-2019 14:30" as "start date" for "Field name"

		@@ -0,0 +1,320 @@
		@api @event
		Feature: context API testing feature.

EWPP-258: Create Behat test for testing "API steps" #315

Are you sure you want to change the base?

EWPP-258: Create Behat test for testing "API steps" #315

Conversation

georgebaev commented Oct 8, 2020

drishu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

georgebaev commented Oct 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment