Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /user/register redirect optional #85

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

claudiu-cristea
Copy link
Contributor

Fixes #83

@claudiu-cristea claudiu-cristea changed the title Maje /user/register redirect optional Make /user/register redirect optional Jun 4, 2019
Copy link
Member

@pfrenssen pfrenssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have some suggestions.

src/Controller/RegisterController.php Outdated Show resolved Hide resolved
behat.yml.dist Show resolved Hide resolved
src/Routing/RouteSubscriber.php Show resolved Hide resolved
src/Routing/RouteSubscriber.php Show resolved Hide resolved
tests/Behat/AuthenticationContext.php Outdated Show resolved Hide resolved
tests/features/ecas-register.feature Outdated Show resolved Hide resolved
tests/features/ecas-register.feature Show resolved Hide resolved
Copy link
Member

@pfrenssen pfrenssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All points made by me and @idimopoulos are addressed, this looks good!

@HermanScis
Copy link

HermanScis commented Jul 9, 2020

@hernani or @imanoleguskiza I think I need the code in here but this pull request has been approved a year ago and is still sitting here... Any plans with this module?

@HermanScis
Copy link

I've tried to revolve the merge conflict in my fork https://github.com/HermanScis/oe_authentication/tree/83-registrer-redirect See #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The /user/register route alway redirects to EU Login
4 participants