Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BPMN for zensus data import and preprocessing #330

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

gplssm
Copy link
Contributor

@gplssm gplssm commented Mar 18, 2020

fix #329

@gplssm gplssm requested a review from IlkaCu March 18, 2020 20:48
Copy link
Member

@IlkaCu IlkaCu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation seems to describe the script 'ego_pp-destatis_zensus_import.sql' correctly, but the input tables 'orig_destatis.zensus_population_per_ha' and orig_destatis.zensus_population_per_ha_grid' do not (anymore) exist in the database.

@gplssm
Copy link
Contributor Author

gplssm commented Mar 24, 2020

Thanks for the hint!
Tables are initially uploaded into orig_destatis tables and the further processed and move elsewhere. I'll update the documentation when automized this section #339. It's quite likely this part will be replaced by some python 🐍

@gplssm gplssm requested a review from IlkaCu April 9, 2020 18:08
@gplssm
Copy link
Contributor Author

gplssm commented Apr 9, 2020

One question come up during updating the BPMN. How to deal with tables that are temporarily used and droped after the end of the section? For example, for importing raw zensus data tmp_destatis.zensus_2011_pop_per_ha is created (plus 2 more tables) and 2 scripts later it's deleted again. By now, I didn't document/colorize the table differently

@IlkaCu
Copy link
Member

IlkaCu commented Aug 20, 2020

As the tables name indicates its temporary use it should be okay to document it in the same way as the permanent tables.

@gplssm gplssm merged commit f3d9844 into dev Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants