Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: approve decision rst 0013 #410

Closed
wants to merge 1 commit into from

Conversation

ilee2u
Copy link
Contributor

@ilee2u ilee2u commented Oct 16, 2024

Description: Approves the decision doc 0013 added in #268 now that the feature from that PR has been implemented.

Dependencies: dependencies on other outstanding PRs, issues, etc.

Merge deadline: Not urgent.

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@ilee2u ilee2u requested a review from a team as a code owner October 16, 2024 18:06
@ilee2u ilee2u mentioned this pull request Oct 16, 2024
11 tasks
@ilee2u ilee2u closed this Oct 17, 2024
@ilee2u ilee2u deleted the ilee2u/approve-decision-0013 branch October 17, 2024 15:17
@ilee2u
Copy link
Contributor Author

ilee2u commented Oct 17, 2024

Closing as this is already addressed in #409 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant