-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update event bus architecture doc to include event_bus_redis #477
docs: update event bus architecture doc to include event_bus_redis #477
Conversation
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
0e31b6c
to
33c1cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Minor proposed fixes/changes.
oeps/architectural-decisions/oep-0052-arch-event-bus-architecture.rst
Outdated
Show resolved
Hide resolved
oeps/architectural-decisions/oep-0052-arch-event-bus-architecture.rst
Outdated
Show resolved
Hide resolved
oeps/architectural-decisions/oep-0052-arch-event-bus-architecture.rst
Outdated
Show resolved
Hide resolved
33c1cab
to
fa7dd46
Compare
Thanks for these changes @navinkarkera! It looks like review is already under way. We'll need to run tests here next; I labeled the PR accordingly. |
Tests run (btw @robrap you can feel free to run tests as well, when you see they need running) |
Hey @robrap, just a friendly reminder that this PR is ready for a second look. |
oeps/architectural-decisions/oep-0052-arch-event-bus-architecture.rst
Outdated
Show resolved
Hide resolved
Also update its status to `Accepted`.
fa7dd46
to
7aeabf2
Compare
@navinkarkera: Can you merge, or do you need me to? Let me know when you are ready. Also, it would be great to follow the OEP process to announce these updates. Thanks! |
@robrap I don't have merge rights. Could you please merge and just to confirm, I'll need to create a forum post in https://discuss.openedx.org/c/announcements/17 to announce this update, or am I missing something. |
@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@navinkarkera: I'm not sure if the forum post automatically goes to Slack or not, but I'd also use Slack. See #493, which I just created. Also, feel free to update the issue I created if you find that the updates automatically go to Slack, because we could note that in OEP-1. |
@robrap Have created a forum topic to announce this change but it needs to be approved by a moderator. It seems that these topics are automatically posted on the slack once published, so I'll wait for the approval. If it doesn't automatically post it, I'll do it manually. |
Also update its status to
Accepted
.