feat: add course reset tab to learner's information #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 88.10% 88.34% +0.23%
==========================================
Files 162 164 +2
Lines 3380 3448 +68
Branches 836 850 +14
==========================================
+ Hits 2978 3046 +68
Misses 398 398
Partials 4 4 ☔ View full report in Codecov by Sentry. |
hajorg
requested review from
jansenk,
BrandonHBodine,
Rodra,
nsprenkle and
leangseu-edx
leangseu-edx
reviewed
Mar 8, 2024
| }, | ||
| ]} | ||
| data={renderResetData} | ||
| styleName="custom-table" |
There was a problem hiding this comment.
Apparently, this is needed for the table style. I'm sorry for the confusion
leangseu-edx
reviewed
Mar 8, 2024
src/users/CourseReset.jsx
Outdated
| return () => clearInterval(intervalId); | ||
| }, [courseResetData]); | ||
|
|
||
| const handleSubmit = async (courseID) => { |
leangseu-edx
reviewed
Mar 8, 2024
src/users/CourseReset.jsx
Outdated
| close(); | ||
| }; | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
this useEffect should be able to combine.
useEffect(() => {
fetchData();
if (data)
...(above code)
else(error)
}, []);There was a problem hiding this comment.
isMounted is unnecessary because [] already make sure it run only once.
There was a problem hiding this comment.
Can you explain what you mean by this useEffect should be able to combine., please?
For the isMounted part, I was getting a warning when running test which is why I added it.
Ali-D-Akbar
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://2u-internal.atlassian.net/browse/AU-1845
Adds Course Reset tab to Learner's Information.
