-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump paragon to v22.13.0, fix minor TypeScript warning #1572
Bump paragon to v22.13.0, fix minor TypeScript warning #1572
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
e21fd3f
to
04511a0
Compare
@farhaanbukhsh could you please review this tiny PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1572 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 326 326
Lines 5614 5615 +1
Branches 1359 1360 +1
=======================================
+ Hits 5045 5046 +1
Misses 554 554
Partials 15 15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@bradenmacdonald what is the reason to increase the bundlesize watch?
- ✅ I tested this: (describe what you tested)
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
@farhaanbukhsh Because the check wasn't passing :/ The new version of Paragon seems to slightly increase the build size. Since it's a small increase I think it's OK for now and I'm hopeful that #1498 will soon let us decrease it. |
The PR #1571 was failing its type checks, so this PR includes the same version bump but also fixes the type issue (on first render, the window size from Paragon's can be
undefined
, in order to avoid hydration errors if using SSR).