-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: find proper courses when searching with active/archived filters on #1496
fix: find proper courses when searching with active/archived filters on #1496
Conversation
Thanks for the pull request, @bra-i-am! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/sumac.master #1496 +/- ##
============================================================
Coverage ? 93.21%
============================================================
Files ? 1050
Lines ? 20412
Branches ? 4369
============================================================
Hits ? 19028
Misses ? 1324
Partials ? 60 ☔ View full report in Codecov by Sentry. |
When active/archived filters were on or there was selected any order filter, the search skipped these values and it was just returned the courses list without the respective filters. Additionally, when a search keyword was applied and a filter was selected, the keyword stayed stuck and the search list returned were not the appropriate
5dd923b
to
6faab7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- ✅ I tested this on Tutor with both Sumac and Master
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository.
e0ec87c
into
openedx:open-release/sumac.master
Description
This PR makes the Studio Home search bar work as expected when are applied archived/active filters. When users attempt to filter for active/archived in combination with the search input, the proper courses are displayed.
useCallback
dependencies so if any of this filters changes, they are applied properly and retrieved the proper dataSupporting information
GitHub Issue: #1477
Testing instructions
Make sure you count on at least one course and do the following:
frontend-app-authoring
MFE to test itArchived
in the dropdown beside the search barActive
and try to look for an archived course