refactor: use getActiveKey to initialize the tab state

on library authoring page.
openedx · Dec 30, 2024 · c59f109 · c59f109
1 parent 4fb6064
commit c59f109
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/src/library-authoring/LibraryAuthoringPage.tsx b/src/library-authoring/LibraryAuthoringPage.tsx
@@ -147,8 +147,10 @@ const LibraryAuthoringPage = ({ returnToLibrarySelection }: LibraryAuthoringPage
   const { insideCollections, insideComponents, navigateTo } = useLibraryRoutes();
 
   // The activeKey determines the currently selected tab.
-  const [activeKey, setActiveKey] = useState<ContentType>(ContentType.home);
   const getActiveKey = () => {
+    if (componentPickerMode) {
+      return ContentType.home;
+    }
     if (insideCollections) {
       return ContentType.collections;
     }
@@ -157,16 +159,7 @@ const LibraryAuthoringPage = ({ returnToLibrarySelection }: LibraryAuthoringPage
     }
     return ContentType.home;
   };
-
-  useEffect(() => {
-    const contentType = getActiveKey();
-
-    if (componentPickerMode) {
-      setActiveKey(ContentType.home);
-    } else {
-      setActiveKey(contentType);
-    }
-  }, []);
+  const [activeKey, setActiveKey] = useState<ContentType>(getActiveKey);
 
   useEffect(() => {
     if (!componentPickerMode) {