Skip to content

Commit

Permalink
Merge pull request #1248 from openedx/feanil/update_proctoring
Browse files Browse the repository at this point in the history
feat!: Drop python 3.8 support
  • Loading branch information
feanil authored Nov 22, 2024
2 parents 3ce3bf9 + 07ab37a commit 528e672
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 25 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
matrix:
os: ["ubuntu-latest"]
python-version: ["3.8", "3.11", "3.12"]
node-version: ["18", "20"]
node-version: ["20"]
toxenv:
[
"django42-drflatest",
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
2 changes: 1 addition & 1 deletion edx_proctoring/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
"""

# Be sure to update the version number in edx_proctoring/package.json
__version__ = '4.18.4'
__version__ = '5.0.0'
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@edx/edx-proctoring",
"//": "Note that the version format is slightly different than that of the Python version when using prereleases.",
"version": "4.18.4",
"version": "5.0.0",
"main": "edx_proctoring/static/index.js",
"scripts": {
"test": "gulp test"
Expand Down
42 changes: 21 additions & 21 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,81 +1,81 @@
[tox]
envlist =
py{38,311,312}-celery{50}-django{42}-drflatest
envlist =
py{311,312}-celery{50}-django{42}-drflatest
quality,
version_check,
pii_check,
translations-django{42}

[testenv]
deps =
deps =
django42: Django>=4.2,<4.3
drflatest: djangorestframework
celery50: -r{toxinidir}/requirements/celery50.txt
-rrequirements/test.txt
commands =
commands =
python -Wd -m pytest {posargs:-n 3}

[testenv:js_tests]
allowlist_externals =
allowlist_externals =
npm
make
commands =
commands =
npm install -g gulp-cli
npm install
make test-js

[testenv:js_lint]
allowlist_externals =
allowlist_externals =
npm
make
commands =
commands =
npm install -g gulp-cli
npm install
make lint-js

[testenv:rst_validation]
allowlist_externals =
allowlist_externals =
make
deps =
deps =
-r{toxinidir}/requirements/quality.txt
commands =
commands =
make quality-rst

[testenv:quality]
allowlist_externals =
allowlist_externals =
make
rm
touch
deps =
deps =
-r{toxinidir}/requirements/quality.txt
-r{toxinidir}/requirements/test.txt
commands =
commands =
pylint edx_proctoring
pycodestyle edx_proctoring
isort --check-only --diff edx_proctoring manage.py setup.py

[testenv:version_check]
deps =
deps =
-r{toxinidir}/requirements/base.txt
commands =
commands =
python {toxinidir}/edx_proctoring/scripts/version_check.py

[testenv:pii_check]
allowlist_externals =
allowlist_externals =
make
deps =
deps =
-r{toxinidir}/requirements/test.txt
Django>=4.2,<4.3
commands =
commands =
make pii_check

[testenv:translations]
allowlist_externals =
allowlist_externals =
make
deps =
django42: Django>=4.2,<4.3
-rrequirements/test.txt
commands =
commands =
sudo apt-get update
sudo apt-get install --no-install-recommends -y gettext
make validate_translations
Expand Down

0 comments on commit 528e672

Please sign in to comment.