Revert "Remove symmath from edx-platform" #29909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
approved these changes
Feb 11, 2022
Carlos-Muniz
approved these changes
Feb 11, 2022
|
Thanks, @kdmccormick & @Carlos-Muniz! |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
|
(The e2e test failure above can be ignored - I reran the test and the failure was intermittent. The subsequent build passed.) |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Carlos-Muniz
pushed a commit
that referenced
this pull request
Feb 14, 2022
* Revert "Merge pull request #29909 from openedx/revert-29869-Carlos-Muniz/symmath-removal" This reverts commit 8c0db8d, reversing changes made to 1156c62. * fix: Remove misplaced `-e` `-e` was wrongfully placed in front of `common/lib/sandbox-packages`, which may have most likely been causing the edxAPP to break. * fix: Change regex to apply to right dirs `py38.txt` does not include `common/lib/xmodule` so it doesn't match the regex. Therefore, it never got its lines in `common/lib/sandbox-packages` fixed. If we change the regex to match any `common/lib/<packagename>` it should work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #29869.
We suspect this commit may cause a build failure. See this #29869 (comment) for the full failure message.
Reverting to test to see if this will make the build green again.