fix: issues with multiple scroll bars

openedx · Jan 23, 2025 · f6659f3 · f6659f3
1 parent db53e68
commit f6659f3
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 9 deletions.
diff --git a/cms/static/sass/course-unit-mfe-iframe-bundle.scss b/cms/static/sass/course-unit-mfe-iframe-bundle.scss
@@ -383,17 +383,31 @@ body {
   }
 
   // Additions for the xblock editor on the Library Authoring
-  &.xblock-iframe-content .xblock-actions {
-    padding: ($baseline*0.75) 2% ($baseline/2) 2%;
+  &.xblock-iframe-content {
+    // Reset the max-height to allow the settings list to grow
+    .wrapper-comp-settings .list-input.settings-list {
+      max-height: unset;
+    }
+
+    // For Google Docs xblock editor
+    #document-settings-tab.google-edit-wrapper .xblock-inputs {
+      position: unset;
+    }
 
-    .action-item {
-      @extend %t-action3;
+    .xblock-actions {
+      padding: ($baseline*0.75) 2% ($baseline/2) 2%;
+      position: sticky;
+      bottom: 0;
 
-      display: inline-block;
-      margin-right: ($baseline*0.75);
+      .action-item {
+        @extend %t-action3;
 
-      &:last-child {
-        margin-right: 0;
+        display: inline-block;
+        margin-right: ($baseline*0.75);
+
+        &:last-child {
+          margin-right: 0;
+        }
       }
     }
   }

diff --git a/common/templates/xblock_v2/xblock_iframe.html b/common/templates/xblock_v2/xblock_iframe.html
@@ -1,6 +1,7 @@
 <!DOCTYPE html>
 
-<html>
+<!-- Set the height of the iframe to 100% of the viewport height to avoid an extra scrollbar -->
+<html style="height: 100vh;">
 <head>
   <!-- Open links in a new tab, not this iframe -->
   <base target="_blank">