feat: remove changing state after revocation

openedx · Jan 13, 2025 · c366335 · c366335
1 parent 0a7f487
commit c366335
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/credentials/apps/badges/issuers.py b/credentials/apps/badges/issuers.py
@@ -33,6 +33,12 @@
 from credentials.apps.credentials.issuers import AbstractCredentialIssuer
 
 
+REVOCATION_STATES = {
+    CredlyBadge: CredlyBadge.STATES.revoked,
+    AccredibleBadge: AccredibleBadge.STATES.expired,
+}
+
+
 class BadgeTemplateIssuer(AbstractCredentialIssuer):
     """
     Issues BadgeTemplate credentials to users.
@@ -76,14 +82,17 @@ def issue_credential(
             UserCredential
         """
 
-        user_credential, __ = self.issued_user_credential_type.objects.update_or_create(
+        user_credential, __ = self.issued_user_credential_type.objects.get_or_create(
             username=username,
             credential_content_type=ContentType.objects.get_for_model(credential),
             credential_id=credential.id,
             defaults={
                 "status": status,
             },
         )
+        if not user_credential.state == REVOCATION_STATES.get(self.issued_user_credential_type):
+            user_credential.status = status
+            user_credential.save()
 
         self.set_credential_attributes(user_credential, attributes)
         self.set_credential_date_override(user_credential, date_override)

diff --git a/credentials/apps/badges/models.py b/credentials/apps/badges/models.py
@@ -624,6 +624,7 @@ class CredlyBadge(UserCredential):
         STATES.pending,
         STATES.accepted,
         STATES.rejected,
+        STATES.revoked,
     }
 
     state = StatusField(