feat: updated to python 3.12 #127
Open
+71
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 4 4
Lines 226 226
Branches 13 8 -5
=======================================
Hits 221 221
Misses 5 5 ☔ View full report in Codecov by Sentry. |
| @@ -309,6 +309,7 @@ def test_missing_block_id(self, url): | |||
| ('org', 'course', 'run', '1', 'category', 'name:more_name', None), | |||
| ) | |||
| @ddt.unpack | |||
| # pylint: disable=too-many-positional-arguments | |||
| def test_valid_locations(self, org, course, run, ccx, category, name, revision): | |||
There was a problem hiding this comment.
Suggested change
| def test_valid_locations(self, org, course, run, ccx, category, name, revision): | |
| def test_valid_locations(self, org, course, run, ccx, category, name, revision): # pylint: disable=too-many-positional-arguments |
There was a problem hiding this comment.
Placing the pylint disable above the function would be better here imo because the function has a long signature with seven arguments. Adding an inline comment would crowd the line, making it harder to read. An above-line comment maintains clarity and improves readability for reviewers and maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For details, see tracking issue #120