Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Revert "Remove bok-choy references" #42

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

timmc-edx
Copy link
Contributor

Reverts #40 to restore automatically generated CSV files. We should either re-run whatever scripts generated the CSV or leave them alone as a historical record.

@salman2013 @feanil

@feanil
Copy link
Contributor

feanil commented Jul 16, 2024

@timmc-edx why does this need to be reverted? Is this data referenced somewhere?

@timmc-edx
Copy link
Contributor Author

I don't recall the details, but I had occasion to look in one of the CSV files and the columns were messed up. I'd prefer that the entire file be either left untouched or deleted outright rather than removing some columns from some rows.

@feanil
Copy link
Contributor

feanil commented Jul 25, 2024

@timmc-edx can you provide any more details? I juts looked through the tools in this repo and it looks like most of them are ancient and no longer relevant. I'm gonna put this repo through the deprecation process rather than fix it up.

@feanil
Copy link
Contributor

feanil commented Jul 25, 2024

Deprecation ticket here: openedx/public-engineering#275

@feanil
Copy link
Contributor

feanil commented Jul 25, 2024

That said, I'm good to merge this so that the data is less mangled in the archived repo. And since it's gonna come out of the org I'm fine with it mentioning other old tech.

@feanil feanil merged commit 29f8e2c into master Jul 25, 2024
2 checks passed
@feanil feanil deleted the revert-40-salman/remove-bok-choy-reference branch July 25, 2024 18:53
@timmc-edx
Copy link
Contributor Author

Sounds good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants