This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
fix: Apply coupon on submitted basket on DPM webhooks fulfillment flow #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n webhooks processing
julianajlk
force-pushed
the
julianajlk/REV-4034/dpm-webhooks-flow-apply-voucher
branch
from
f169e91 to
a3dfb79
Compare
julianajlk
force-pushed
the
julianajlk/REV-4034/dpm-webhooks-flow-apply-voucher
branch
from
a3dfb79 to
fc8dee5
Compare
christopappas
approved these changes
May 10, 2024
julianajlk
force-pushed
the
julianajlk/REV-4034/dpm-webhooks-flow-apply-voucher
branch
from
58cd341 to
05ca82b
Compare
julianajlk
deleted the
julianajlk/REV-4034/dpm-webhooks-flow-apply-voucher
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that when a voucher is applied to the basket throughout the payment flow, it is never saved.
This resulted in a strange side effect, where when we get the basket in another instance (webhooks), the voucher is not applied to the basket, even though this basket has been submitted.