feat(test): Add UT for cstor, lvm, zfs storage package #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 23, 2021 00:53
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
6 tasks
Abhinandan-Purkait
approved these changes
Jul 26, 2021
added 2 commits
July 26, 2021 09:56
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
| } | ||
| util.TablePrinter(util.CstorPoolListColumnDefinations, rows, printers.PrintOptions{Wide: true}) | ||
| return nil | ||
| return util.CstorPoolListColumnDefinations, rows, nil |
There was a problem hiding this comment.
Thank you, for this change.
Abhinandan-Purkait
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
kubectl openebs get storage --cas-type=cstordisplays theAGEof the CStor pool, this value shouldn't be compared, as thetime.Sincecannot be mocked very easily without doing semi-crazy things, the golang playground has done something similar but I don't know how the same can be achieved without monkeypatchingSigned-off-by: Harsh Vardhan [email protected]