Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Rebuild IO handles #1755

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Reuse Rebuild IO handles #1755

merged 3 commits into from
Oct 17, 2024

Commits on Oct 11, 2024

  1. refactor(rebuild): rebuild completion is not an error

    When the rebuild has been complete, if we wait for it this fails because
    the channels are not longer available.
    Instead, simply return the rebuild state, since this is what we want anyway.
    
    Signed-off-by: Tiago Castro <[email protected]>
    tiagolobocastro committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1bec7bb View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. fix(rebuild): reuse rebuild IO handles

    Reuses the rebuild IO handles, rather than attempting to allocate
    them per rebuild task.
    The main issue with handle allocation on the fly is that the target
    may have not cleaned up a previous IO qpair connection, and so the
    connect may fail. We started seeing this more on CI because we forgot
    to cherry-pick a commit increasing the retry delay.
    However, after inspecting a bunch of user support bundles I see that
    we still have occasional connect errors. Rather than increasing the
    timeout, we attempt here to reuse the handles, thus avoid the
    problem almost entirely.
    
    Signed-off-by: Tiago Castro <[email protected]>
    tiagolobocastro committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    554005c View commit details
    Browse the repository at this point in the history
  2. build: update spdk-rs to the latest

    Brings in latest fixes and improvements.
    
    Signed-off-by: Tiago Castro <[email protected]>
    tiagolobocastro committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b59bc00 View commit details
    Browse the repository at this point in the history