-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(upgrade): remove etcd.initialClusterState from helm values #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
tiagolobocastro,
Abhinandan-Purkait and
dsharma-dc
January 6, 2025 17:44
niladrih
force-pushed
the
initClusterState
branch
from
January 6, 2025 17:46
ba2b70b
to
9a67f73
Compare
Abhinandan-Purkait
approved these changes
Jan 7, 2025
tiagolobocastro
approved these changes
Jan 8, 2025
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
595: fix(upgrade): remove etcd.initialClusterState from helm values r=niladrih a=niladrih Fixes openebs/mayastor#1735 This removes the helm value for the key etcd.initialClusterState for all versions greater than or equal to 2.0.0-rc.0 and less than 2.7.3. Co-authored-by: Niladri Halder <[email protected]>
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"Required status check \"helm-chart-test\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
niladrih
force-pushed
the
initClusterState
branch
from
January 8, 2025 20:14
9a67f73
to
72a15d7
Compare
bors merge |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Fixes openebs/mayastor#1735 This removes the helm value for the key etcd.initialClusterState for all versions greater than or equal to 2.0.0-rc.0 and less than 2.7.3. Signed-off-by: Niladri Halder <[email protected]>
niladrih
force-pushed
the
initClusterState
branch
from
January 20, 2025 07:13
72a15d7
to
5d8ecce
Compare
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openebs/mayastor#1735
This removes the helm value for the key etcd.initialClusterState for all versions greater than or equal to 2.0.0-rc.0 and less than 2.7.3.