build: add option to explictly set RUSTFLAGS #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reads the env RUSTFLAGS from the env and passes it to nix-build as an argstr. Signed-off-by: Niladri Halder <[email protected]>
niladrih
requested review from
tiagolobocastro,
Abhinandan-Purkait and
dsharma-dc
tiagolobocastro
approved these changes
Oct 23, 2024
Abhinandan-Purkait
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads the env RUSTFLAGS from the env and passes it to nix-build as an argstr.
--extra-build-argsmakes it difficult to provide as an input due to the shell's interpretation of""and the style of arg handling that we use on release.sh. Using an env to avoid breaking the extra-args bit into a space-separated string array.As of now, extra-args doesn't have many use-cases that I know of. However, I've recently stumbled on to a CI issue where being able to set RUSTFLAGS globally would be useful.