feat(charts): add global.imageRegistry parameter #227
Conversation
|
I tried to force push to re-run the CI job, it seems to have failed before installing the chart in the integration test. |
|
I suspect we need something like this: https://github.com/openebs/lvm-localpv/pull/357/files |
|
CC @niladrih |
|
CI check fails due to CI issue. Fix: #229. |
|
@LKummer could you please rebase your branch? The CI should run better after the recent changes. |
Add global.imageRegistry option overridden by localpv.image.registry and helperPod.image.registry for localpv and helper Pod respectively. Fix registry options requiring a trailing slash while still supporting a trailing slash to avoid breaking existing configurations. Signed-off-by: Lior Friedman <[email protected]>
Signed-off-by: Lior Friedman <[email protected]>
Signed-off-by: Lior Friedman <[email protected]>
|
Thank you @niladrih, I've rebased my branch. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #227 +/- ##
===========================================
- Coverage 37.91% 37.35% -0.57%
===========================================
Files 36 1 -35
Lines 3373 779 -2594
===========================================
- Hits 1279 291 -988
+ Misses 2012 479 -1533
+ Partials 82 9 -73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -45,7 +45,7 @@ spec: | |||
| {{- toYaml .Values.podSecurityContext | nindent 8 }} | |||
| containers: | |||
| - name: {{ template "localpv.fullname" . }} | |||
| image: "{{ .Values.localpv.image.registry }}{{ .Values.localpv.image.repository }}:{{ .Values.localpv.image.tag }}" | |||
| image: "{{ with .Values.localpv.image.registry | default .Values.global.imageRegistry | trimSuffix "/" }}{{ . }}/{{ end }}{{ .Values.localpv.image.repository }}:{{ .Values.localpv.image.tag }}" | |||
There was a problem hiding this comment.
nit: a function in helpers might be good to have here
|
Thanks for this change @LKummer. I'll merge when you resolve the review conversation (as in click on the 'Resolve conversation' button, up to you if you'll take the suggestion or not). |
Pull Request template
Why is this PR required? What issue does it fix?:
Fixes #203.
What this PR does?:
global.imageRegistryHelm parameter for specifying an image registry to be used for all images. It is overridden bylocalpv.image.registryandhelperPod.image.registrywhen specified./, while still supporting a trailing/to avoid breaking existing configurations.Does this PR require any upgrade changes?:
No.
If the changes in this PR are manually verified, list down the scenarios covered::
global.imageRegistryset without trailing/.global.imageRegistryandlocalpv.image.registryset without trailing/.global.imageRegistryandhelperPod.image.registryset without trailing/.global.imageRegistry,localpv.image.registryandhelperPod.image.registryset without trailing/.localpv.image.registryset with trailing/.helperPod.image.registryset with trailing/.Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
No.
Checklist:
<type>(<scope>): <subject>