Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/NVPE-10: Create NIM Account controller #289

Merged
merged 23 commits into from
Nov 14, 2024
Merged

Task/NVPE-10: Create NIM Account controller #289

merged 23 commits into from
Nov 14, 2024
+2,045 −5

Commits on Nov 14, 2024

  1. feat: added nim account controller 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2c18ef8 View commit details
    Browse the repository at this point in the history

  2. test: added tests for the new nim account controller 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d7b2d07 View commit details
    Browse the repository at this point in the history

  3. chore: fixed change request, owned resources are deleted by k8s gc 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0158e82 View commit details
    Browse the repository at this point in the history

  4. chore: fixed change request, rearrange status conditions reporting 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8d7b462 View commit details
    Browse the repository at this point in the history

  5. chore: fixed change request, use server side apply where applicable 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8eab67f View commit details
    Browse the repository at this point in the history

  6. docs: clarified code docs 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0ed4967 View commit details
    Browse the repository at this point in the history

  7. chore: switched to utility func for gvk fetch 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7cf4a5b View commit details
    Browse the repository at this point in the history

  8. chore: added count to utility script 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ff4f982 View commit details
    Browse the repository at this point in the history

  9. fix: cleanup resources if failed to validate the api key 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d250bee View commit details
    Browse the repository at this point in the history

  10. test: fixed failing ci test (worked locally) 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    85c9c8b View commit details
    Browse the repository at this point in the history

  11. fix: added pagesize to catalog query 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d93ee30 View commit details
    Browse the repository at this point in the history

  12. fix: added missing rbac for account status 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    58c0d41 View commit details
    Browse the repository at this point in the history

  13. chore: fixed change request, clarify variable name 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ad4804e View commit details
    Browse the repository at this point in the history

  14. fix: intial account stauts should be unknown 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    84855cd View commit details
    Browse the repository at this point in the history

  15. chore: fixed various small change request 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    33a822e View commit details
    Browse the repository at this point in the history

  16. fix: several fixes and requests 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b1f2aab View commit details
    Browse the repository at this point in the history

  17. test: fixed flaky test 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c78583b View commit details
    Browse the repository at this point in the history

  18. fix: missing finalizer permissions 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    eb06f7d View commit details
    Browse the repository at this point in the history

  19. fix: missing create perms for templates 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e11013c View commit details
    Browse the repository at this point in the history

  20. test: made test more reliable 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c6d0853 View commit details
    Browse the repository at this point in the history

  21. test: fixed flaky test by increasing timeout 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7100903 View commit details
    Browse the repository at this point in the history

  22. fix: wrong type of pull secret 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    82eefad View commit details
    Browse the repository at this point in the history

  23. test: nim account should be created in seperated namespace per testcases 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2377baf View commit details
    Browse the repository at this point in the history