-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance visit with login #3469
Enhance visit with login #3469
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
.../__tests__/cypress/cypress/tests/e2e/settings/clusterSettings/testAdminClusterSettings.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/e2e/storageClasses/clusterStorage.cy.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3469 +/- ##
==========================================
- Coverage 85.65% 85.65% -0.01%
==========================================
Files 1347 1347
Lines 30676 30676
Branches 8554 8554
==========================================
- Hits 26275 26274 -1
- Misses 4401 4402 +1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…odh-dashboard into fix/enhance_visit_with_login
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manosnoam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-15671
Description
We are having some issues when trying to use a contributor role user (not an admin one) in the e2e as we depend on an already created test-variables.yml.
That file, has the contributor user stored as TEST_USER_3.
How Has This Been Tested?
Locally, running against a 2.16 RHOAI cluster
Test Impact
This is a modification of the way the users log in the tests. So full impact.
Request review criteria:
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main