-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix name overflow on deployed model card #3465
Fix name overflow on deployed model card #3465
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3465 +/- ##
=======================================
Coverage 85.66% 85.66%
=======================================
Files 1347 1347
Lines 30670 30679 +9
Branches 8550 8554 +4
=======================================
+ Hits 26272 26280 +8
- Misses 4398 4399 +1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truncated text is looking great here @ashley-o0o ! There's just a small bug that's preventing the tooltip from rendering when the text is hovered - we'll want use the same approach to wrapping the Truncate
component with a Button
as we currently do in ProjectCard :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jenny-s51 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-13078
Description
Fixes a bug where model names over 55+ characters overflow off of the deployed model card. It will now truncate at the end. It will also show a tooltip for names that are truncated.
How Has This Been Tested?
Tested locally
Test Impact
No new tests added
Screenshots
Before:
After:
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main