-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Modify NIM enablement process #3455
feat: Modify NIM enablement process #3455
Conversation
Hi @yzhao583. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…elated tile in the enable application page, should not remove the tile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Co-authored-by: Andrew Ballantyne <[email protected]>
Co-authored-by: Andrew Ballantyne <[email protected]>
…one. Signed-off-by: Olga Lavtar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me delete some resources on dev04 and give this a shot for real this time
31e45b4
to
ac93af3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got some issues around the useWatchIntegrationComponents
hook...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are close... if we can restructure the new file to not have its own lifecycle and implementation we should be close to good to go. I'll test on the Dev04 cluster and see about how this all works out.
Signed-off-by: Olga Lavtar <[email protected]>
7899002
to
203ce77
Compare
Signed-off-by: Olga Lavtar <[email protected]>
Signed-off-by: Olga Lavtar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, 18 comments... not all of these are important for this PR. Lets get the critical ones done first, everything else needs to be logged and another PR put up asap to avoid it not getting done. I'll mark them in 3 stages for simplicity.
🔴 will need to be done -- they are critical / blockers to this PR. (there are 5 of them -- 2 backend, 2 around the mock, 1 delete file)
🟡 will need to be followed up -- but can miss the 2.16; more quality stuff
🟢 are stuff we need to address over time -- likely best to log issues and just approach them asap when time/duty permits
<Button | ||
variant={ButtonVariant.secondary} | ||
onClick={onEnable} | ||
isDisabled={!enablement || !canInstall} | ||
isLoading={!loaded && !error} | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 As noted in our discussions there are some issues around this button; making them again here for posterity.
- Button doesn't hide after install (after modal closes)
- Button loads then hides if installed
- I noticed this recently and didn't say anything -- but the
isLoading
probably should be a Skeleton component until if we know it should be there or not
- I noticed this recently and didn't say anything -- but the
- Button shows disabled but doesn't show why -- before it was just
enablement
feature but now it's possible there is another feature flag or criteria from the API
); | ||
|
||
if (response.error) { | ||
// TODO: Show the error somehow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 We filtered out the item -- so this may end up needing to be a toast -- but those can be kinda finicky -- we don't want to spam it. We'll have to look into our options for this one.
Signed-off-by: Olga Lavtar <[email protected]>
Signed-off-by: Olga Lavtar <[email protected]>
Signed-off-by: Olga Lavtar <[email protected]>
Signed-off-by: Olga Lavtar <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3455 +/- ##
==========================================
- Coverage 85.59% 85.38% -0.21%
==========================================
Files 1344 1352 +8
Lines 30552 30860 +308
Branches 8471 8612 +141
==========================================
+ Hits 26150 26349 +199
- Misses 4402 4511 +109
... and 91 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Modify NIM enablement process * Clean up code and remove unnecessary manifests * Add logic to check the conditions of the odh-nim-account CR * Added more check for enabled integration apps * If failed to fetch integration app status, should show error on the related tile in the enable application page, should not remove the tile * check integration app status in explore application page * Fix lint issue * Fix lint issue * add annotations to the secret and the account CR * Update backend/src/routes/api/integrations/nim/index.ts Co-authored-by: Andrew Ballantyne <[email protected]> * Update backend/src/routes/api/components/list.ts Co-authored-by: Andrew Ballantyne <[email protected]> * clean up * feat: listing all NIM accounts in the namespace, returning the first one. Signed-off-by: Olga Lavtar <[email protected]> * Avoid mutating object in useWatchIntegrationComponents * Clean up * feat: added logic for displaying the tile correctly Signed-off-by: Olga Lavtar <[email protected]> * feat: changes for enabling Signed-off-by: Olga Lavtar <[email protected]> * feat: updated mock component with the new properties. Signed-off-by: Olga Lavtar <[email protected]> * feat: addressed PR comments with updates and improvements Signed-off-by: Olga Lavtar <[email protected]> * feat: backend bug fix Signed-off-by: Olga Lavtar <[email protected]> * feat: Missed change from previous commit Signed-off-by: Olga Lavtar <[email protected]> * feat: fix for the enabled page and enabled.cy.ts Signed-off-by: Olga Lavtar <[email protected]> --------- Signed-off-by: Olga Lavtar <[email protected]> Co-authored-by: Andrew Ballantyne <[email protected]> Co-authored-by: Olga Lavtar <[email protected]>
* feat: added ability to deploy more than one NIM model. (#3453) * feat: added ability to deploy more than one NIM model. Signed-off-by: Olga Lavtar <[email protected]> * feat: refactored NIM related logic to nimUtils Signed-off-by: Olga Lavtar <[email protected]> * feat: changes to the error handling Signed-off-by: Olga Lavtar <[email protected]> * feat: changes to the error handling Signed-off-by: Olga Lavtar <[email protected]> * feat: changes .some for .forEach Signed-off-by: Olga Lavtar <[email protected]> * feat: deleting secrets fix Signed-off-by: Olga Lavtar <[email protected]> * feat: deploying the same model pvc fix Signed-off-by: Olga Lavtar <[email protected]> * feat: added a unit test for getNIMResourcesToDelete Signed-off-by: Olga Lavtar <[email protected]> * feat: will add a unit test for getNIMResourcesToDelete later Signed-off-by: Olga Lavtar <[email protected]> --------- Signed-off-by: Olga Lavtar <[email protected]> * feat: Modify NIM enablement process (#3455) * Modify NIM enablement process * Clean up code and remove unnecessary manifests * Add logic to check the conditions of the odh-nim-account CR * Added more check for enabled integration apps * If failed to fetch integration app status, should show error on the related tile in the enable application page, should not remove the tile * check integration app status in explore application page * Fix lint issue * Fix lint issue * add annotations to the secret and the account CR * Update backend/src/routes/api/integrations/nim/index.ts Co-authored-by: Andrew Ballantyne <[email protected]> * Update backend/src/routes/api/components/list.ts Co-authored-by: Andrew Ballantyne <[email protected]> * clean up * feat: listing all NIM accounts in the namespace, returning the first one. Signed-off-by: Olga Lavtar <[email protected]> * Avoid mutating object in useWatchIntegrationComponents * Clean up * feat: added logic for displaying the tile correctly Signed-off-by: Olga Lavtar <[email protected]> * feat: changes for enabling Signed-off-by: Olga Lavtar <[email protected]> * feat: updated mock component with the new properties. Signed-off-by: Olga Lavtar <[email protected]> * feat: addressed PR comments with updates and improvements Signed-off-by: Olga Lavtar <[email protected]> * feat: backend bug fix Signed-off-by: Olga Lavtar <[email protected]> * feat: Missed change from previous commit Signed-off-by: Olga Lavtar <[email protected]> * feat: fix for the enabled page and enabled.cy.ts Signed-off-by: Olga Lavtar <[email protected]> --------- Signed-off-by: Olga Lavtar <[email protected]> Co-authored-by: Andrew Ballantyne <[email protected]> Co-authored-by: Olga Lavtar <[email protected]> * Fix NIM selection issue (#3482) * Fix NIM selection issue * Switch back to using a numerical value --------- Signed-off-by: Olga Lavtar <[email protected]> Co-authored-by: olavtar <[email protected]> Co-authored-by: yu zhao <[email protected]> Co-authored-by: Olga Lavtar <[email protected]>
https://issues.redhat.com/browse/NVPE-22
Description
Change the enablement process for NIM on the dashboard.
How Has This Been Tested?
Tested locally.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main