feat: added ability to deploy more than one NIM model.

[olavtar]

https://issues.redhat.com/browse/NVPE-15

Description

Ability to deploy more than one NIM model.

How Has This Been Tested?

Tested locally.

Test Impact

• Manually tested the UI to confirm that multiple deployed models display accurately.
• Verified the Deploy button appears on the Model Serving screen.
• Verified the Deploy button appears on the Models tab under Data Science Project
• Ensured that Secrets are not getting deleted if more than 1 deployment is present within the same namespace
• Ensured that PVC does get deleted regardless of how many deployments are present within the same namespace

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[openshift-ci]

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 69.86301% with 22 lines in your changes missing coverage. Please review.

Project coverage is 85.61%. Comparing base (6f439e5) to head (f6d2c37).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...rc/pages/modelServing/screens/projects/nimUtils.ts	60.00%	12 Missing ⚠️
...ing/screens/global/DeleteInferenceServiceModal.tsx	77.77%	4 Missing ⚠️
...projects/NIMServiceModal/ManageNIMServingModal.tsx	78.57%	3 Missing ⚠️
...d/src/pages/modelServing/screens/projects/utils.ts	66.66%	2 Missing ⚠️
...lServing/screens/projects/ModelServingPlatform.tsx	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3453      +/-   ##
==========================================
- Coverage   85.65%   85.61%   -0.04%     
==========================================
  Files        1347     1347              
  Lines       30676    30704      +28     
  Branches     8554     8554              
==========================================
+ Hits        26275    26287      +12     
- Misses       4401     4417      +16     

Files with missing lines	Coverage Δ
...lServing/screens/projects/ModelServingPlatform.tsx	99.08% <80.00%> (-0.02%)	⬇️
...d/src/pages/modelServing/screens/projects/utils.ts	94.33% <66.66%> (-0.69%)	⬇️
...projects/NIMServiceModal/ManageNIMServingModal.tsx	86.92% <78.57%> (+0.03%)	⬆️
...ing/screens/global/DeleteInferenceServiceModal.tsx	86.48% <77.77%> (-1.52%)	⬇️
...rc/pages/modelServing/screens/projects/nimUtils.ts	84.94% <60.00%> (-11.93%)	⬇️

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f439e5...f6d2c37. Read the comment docs.

[andrewballantyne]

/ok-to-test

[andrewballantyne]

Code-level changes/questions -- testing it out.

[andrewballantyne]

Since you updated the logic to throw an error -- instead of returning 0 -- the only way to get into this block is if you don't have the resources... did we want to try and delete the PVC still? Or... not?

[olavtar]

the if (count === 0) condition has been removed.

[andrewballantyne]

Anyway we can get a unit test for this? It seems the logic is not working as expected (at least on the cluster)

[andrewballantyne]

Works as expected.

Couldn't reproduce the two model PVC issue & the secrets get cleaned up.

/hold

@olavtar Can you let me know what issue it is for the unit test or push it to this PR? I want to make sure we have that covered in the backlog or in this PR itself. Thanks!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andrewballantyne]

Discussed with Olga -- tests are done but have an issue -- unholding to wrap up one more thing in the NIM space.

/unhold

[olavtar]

Jira for unit test: https://issues.redhat.com/browse/NVPE-33