Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable connection types by default #3452

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-14748

Description

How Has This Been Tested?

  • apply the CRD changes to your test cluster, thus removing the disableConnectionTypes feature flag
  • if testing locally, run a local backend server with the changes
  • observe the UI shows connection types enabled by default

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @andrewballantyne @dgutride @emilys314

@christianvogt christianvogt added the do-not-merge/hold This PR is hold for some reason label Nov 7, 2024
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever you get PM approval

Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.66%. Comparing base (0e4420f) to head (474c7f4).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3452      +/-   ##
==========================================
+ Coverage   85.64%   85.66%   +0.01%     
==========================================
  Files        1347     1347              
  Lines       30661    30668       +7     
  Branches     8531     8537       +6     
==========================================
+ Hits        26261    26273      +12     
+ Misses       4400     4395       -5     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4420f...474c7f4. Read the comment docs.

@emilys314
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Nov 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c575d1f into opendatahub-io:main Nov 12, 2024
6 checks passed
manaswinidas pushed a commit to manaswinidas/odh-dashboard that referenced this pull request Nov 13, 2024
openshift-merge-bot bot pushed a commit that referenced this pull request Nov 13, 2024
* Upversion Dashboard

* Check and use response of connection saving (#3462)

(cherry picked from commit 4066b69)

* enable connection types by default (#3452)

(cherry picked from commit c575d1f)

---------

Co-authored-by: Emily Samoylov <[email protected]>
Co-authored-by: Christian Vogt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants