-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable connection types by default #3452
enable connection types by default #3452
Conversation
63c650e
to
474c7f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever you get PM approval
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3452 +/- ##
==========================================
+ Coverage 85.64% 85.66% +0.01%
==========================================
Files 1347 1347
Lines 30661 30668 +7
Branches 8531 8537 +6
==========================================
+ Hits 26261 26273 +12
+ Misses 4400 4395 -5 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/unhold |
(cherry picked from commit c575d1f)
* Upversion Dashboard * Check and use response of connection saving (#3462) (cherry picked from commit 4066b69) * enable connection types by default (#3452) (cherry picked from commit c575d1f) --------- Co-authored-by: Emily Samoylov <[email protected]> Co-authored-by: Christian Vogt <[email protected]>
https://issues.redhat.com/browse/RHOAIENG-14748
Description
How Has This Been Tested?
disableConnectionTypes
feature flagTest Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @andrewballantyne @dgutride @emilys314