Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent deletion of active connection secrets when updating note… #3445

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Nov 6, 2024

https://issues.redhat.com/browse/RHOAIENG-15228

Description

The system incorrectly deletes active connection secrets when updating notebook environment variables, potentially causing disruption to running connections.

How Has This Been Tested?

  1. Create a notebook with environment variables
  2. Set up an connection to a data connection
  3. Set up other connection types as well (turn dat feature flag on)
  4. save
  5. edit
  6. Observe that the active connection secrets are not incorrectly deleted and the warning message is not there

Test Impact

none

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.62%. Comparing base (9242b81) to head (271ad1f).
Report is 24 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3445      +/-   ##
==========================================
+ Coverage   85.56%   85.62%   +0.06%     
==========================================
  Files        1344     1346       +2     
  Lines       30549    30596      +47     
  Branches     8468     8507      +39     
==========================================
+ Hits        26138    26197      +59     
+ Misses       4411     4399      -12     
Files with missing lines Coverage Δ
...c/pages/projects/screens/spawner/SpawnerFooter.tsx 84.74% <ø> (ø)
...src/pages/projects/screens/spawner/SpawnerPage.tsx 97.05% <100.00%> (+0.08%) ⬆️
...r/environmentVariables/useNotebookEnvVariables.tsx 86.95% <100.00%> (ø)
...ects/screens/spawner/environmentVariables/utils.ts 100.00% <100.00%> (ø)
...tend/src/pages/projects/screens/spawner/service.ts 78.98% <100.00%> (+0.30%) ⬆️

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9242b81...271ad1f. Read the comment docs.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works well.
/lgtm

@Gkrumbach07
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 01d0519 into opendatahub-io:main Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants