Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-12866] entire project context refreshed when individual resources are deleted #3437

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Nov 5, 2024

https://issues.redhat.com/browse/RHOAIENG-12866

Description

Updated usages of project details context to not refresh all resources after certain actions like the one mentioned in this ticket take place (e.g. deletion of data connections).

How Has This Been Tested?

Inspected browser network - After deleting data connections, additional API requests for other resources (e.g. fetching of notebooks) no longer occur. This can be done to manually test, or the deletion of cluster storage from the project details page.

Since there was no change in functionality, no additional tests were added for this change.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-12866 branch 3 times, most recently from c5ab200 to 4ff015f Compare November 7, 2024 17:56
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.65%. Comparing base (3658290) to head (63b8ddd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...MeshSection/ServingRuntimeTableExpandedSection.tsx 50.00% 1 Missing ⚠️
...c/pages/projects/screens/detail/ProjectDetails.tsx 91.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3437      +/-   ##
==========================================
- Coverage   85.65%   85.65%   -0.01%     
==========================================
  Files        1347     1347              
  Lines       30680    30670      -10     
  Branches     8550     8550              
==========================================
- Hits        26280    26271       -9     
+ Misses       4400     4399       -1     
Files with missing lines Coverage Δ
...ntend/src/pages/projects/ProjectDetailsContext.tsx 88.63% <ø> (-3.68%) ⬇️
...ns/detail/data-connections/DataConnectionsList.tsx 100.00% <100.00%> (ø)
...projects/screens/detail/notebooks/NotebookList.tsx 100.00% <100.00%> (ø)
...es/projects/screens/detail/storage/StorageList.tsx 100.00% <100.00%> (ø)
...c/pages/projects/screens/spawner/SpawnerFooter.tsx 84.87% <100.00%> (+0.12%) ⬆️
...MeshSection/ServingRuntimeTableExpandedSection.tsx 80.95% <50.00%> (-0.87%) ⬇️
...c/pages/projects/screens/detail/ProjectDetails.tsx 96.42% <91.66%> (-0.24%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3658290...63b8ddd. Read the comment docs.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well, now we don't refresh all project resources and only re-fetch the resources as needed.
/lgtm

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed some issues, see the comments below. I think after that update everything should be good.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 7, 2024
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2024
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e85d7a1 into opendatahub-io:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants