Fix issues after 0.14.0 sync #424
Conversation
Signed-off-by: jooho lee <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: jooho lee <[email protected]>
Signed-off-by: jooho lee <[email protected]>
Signed-off-by: jooho lee <[email protected]>
Jooho
force-pushed
the
0.14_sync_issues
branch
from
010847f
to
933e3c7
Compare
|
@Jooho: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -0,0 +1,763 @@ | |||
| --- | |||
| apiVersion: apiextensions.k8s.io/v1 | |||
There was a problem hiding this comment.
Yes. I also don't understand why this is needed.
There was a problem hiding this comment.
because odh-model-controller look for this by default
| oc patch DataScienceCluster test-dsc --type='json' -p='[{"op": "replace", "path": "/spec/components/kserve/defaultDeploymentMode", "value": "RawDeployment"}]' | ||
| else | ||
| export OPENSHIFT_INGRESS_DOMAIN=$(oc get ingresses.config cluster -o jsonpath='{.spec.domain}') | ||
| oc patch configmap inferenceservice-config -n kserve --patch-file <(cat config/overlays/test/configmap/inferenceservice-openshift-ci-serverless.yaml | envsubst) |
There was a problem hiding this comment.
I'm confused about why you need to configure the ingress domain here.
In the comment docs, it is stated that this is only relevant for RawDeployment, but Raw is covered in the other branch of the if
| @@ -0,0 +1,763 @@ | |||
| --- | |||
| apiVersion: apiextensions.k8s.io/v1 | |||
There was a problem hiding this comment.
Yes. I also don't understand why this is needed.
Signed-off-by: jooho lee <[email protected]>
What this PR does / why we need it:
webhookconfigurationto fix kustomize build issue.predictor,path_based_routing,rawWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.