-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-13089: Add global CM default values for the inference logger CA bundle #418
base: release-v0.12.1
Are you sure you want to change the base?
RHOAIENG-13089: Add global CM default values for the inference logger CA bundle #418
Conversation
Signed-off-by: Rui Vieira <[email protected]>
@ruivieira: This pull request references RHOAIENG-13089 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
@ruivieira: This pull request references RHOAIENG-13089 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Others PTAL
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruivieira, spolti, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
"defaultUrl": "http://default-broker", | ||
"caBundle": "kserve-logger-ca-bundle", | ||
"caCertFile": "service-ca.crt", | ||
"tlsSkipVerify": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure even though we accept this config, it will work or not because to support global cert from kserve, odh-model-controller overwrites this value with storage-config.
What this PR does / why we need it:
Add default values to the global configuration CM for the logger's CA bundle.
This PR is needed in order to KServe detect the specified CA bundle and use it to configure TLS requests from the InferenceLogger (as implemented with #417).
This PR should be merged after #417, ideally.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.